feat(new-registration): add flows anonymous usage data (WPB-17529) #4088

yamilmedina · 2025-06-27T14:52:57Z

WPB-17529 [Android] New Registration Flows - Personal account countly tracking

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

As a part of the final step for new registration flows we need to provide countly tracking in case the user allows it.

Solutions

Implement it by reusing some parts like the initialization code configuration (half of this is on kalium)
Handle initialization properly according to environment allowance (only staging and prod)
Add the tracking logic events for the flows
Carry over the identifier id for the freshly created user
Fix/ hide the sync bar on the new registrations flows (https://wearezeta.atlassian.net/browse/WPB-18399)

Needs release with

feat(new-registration): add use case to set analytics ID from the app (WPB-17529) kalium#3494

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Connect to staging or prod, go to Analytics dashboard and see the events there when the consent by the user was granted.

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…ytics

...src/main/kotlin/com/wire/android/ui/registration/details/CreateAccountDataDetailViewModel.kt

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt

...-enabled/src/main/kotlin/com/wire/android/feature/analytics/AnonymousAnalyticsManagerImpl.kt

alexandreferris

Nice!

I don't have much to add to your amazing work 🔥 just a very small nitpick comment that I also might be wrong 😅

Apart from that, awaiting for the approvals 👌🏻

app/src/main/kotlin/com/wire/android/analytics/FinalizeRegistrationAnalyticsMetadataUseCase.kt

codecov · 2025-06-27T16:25:36Z

Codecov Report

Attention: Patch coverage is 71.25000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 47.82%. Comparing base (6d74cf2) to head (91ac6c0).
Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
...tlin/com/wire/android/datastore/GlobalDataStore.kt	13.33%	13 Missing ⚠️
...tlin/com/wire/android/util/CurrentScreenManager.kt	0.00%	4 Missing ⚠️
...ion/code/CreateAccountVerificationCodeViewModel.kt	0.00%	3 Missing ⚠️
...rc/main/kotlin/com/wire/android/WireApplication.kt	0.00%	1 Missing ⚠️
...cs/FinalizeRegistrationAnalyticsMetadataUseCase.kt	90.00%	0 Missing and 1 partial ⚠️
...analytics/ObserveCurrentSessionAnalyticsUseCase.kt	95.65%	0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (71.25%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4088      +/-   ##
===========================================
+ Coverage    47.73%   47.82%   +0.08%     
===========================================
  Files          502      504       +2     
  Lines        17649    17716      +67     
  Branches      2909     2917       +8     
===========================================
+ Hits          8425     8472      +47     
- Misses        8341     8362      +21     
+ Partials       883      882       -1

Files with missing lines	Coverage Δ
.../create/username/CreateAccountUsernameViewModel.kt	`100.00% <100.00%> (ø)`
...ration/details/CreateAccountDataDetailViewModel.kt	`77.31% <100.00%> (+5.55%)`	⬆️
...in/com/wire/android/util/ServerConfigExtensions.kt	`100.00% <100.00%> (ø)`
...rc/main/kotlin/com/wire/android/WireApplication.kt	`0.00% <0.00%> (ø)`
...cs/FinalizeRegistrationAnalyticsMetadataUseCase.kt	`90.00% <90.00%> (ø)`
...analytics/ObserveCurrentSessionAnalyticsUseCase.kt	`91.66% <95.65%> (+2.30%)`	⬆️
...ion/code/CreateAccountVerificationCodeViewModel.kt	`0.00% <0.00%> (ø)`
...tlin/com/wire/android/util/CurrentScreenManager.kt	`25.00% <0.00%> (-1.05%)`	⬇️
...tlin/com/wire/android/datastore/GlobalDataStore.kt	`19.04% <13.33%> (-1.79%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d74cf2...91ac6c0. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2025-06-27T17:03:41Z

Built wire-android-staging-compat-pr-4088.apk is available for download

github-actions · 2025-06-27T17:03:57Z

Built wire-android-dev-debug-pr-4088.apk is available for download

github-actions · 2025-07-03T10:33:36Z

Built wire-android-staging-compat-pr-4088.apk is available for download

github-actions · 2025-07-03T10:34:02Z

Built wire-android-dev-debug-pr-4088.apk is available for download

sonarqubecloud · 2025-07-03T12:35:30Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-07-03T13:41:07Z

Built wire-android-staging-compat-pr-4088.apk is available for download

github-actions · 2025-07-03T13:41:20Z

Built wire-android-dev-debug-pr-4088.apk is available for download

yamilmedina added 20 commits June 18, 2025 10:22

fix: general fixes about navigation and copies

1db38d7

feat: implement analytics changes for new reg

eab79c6

feat: pr comments

7c09f70

feat: detekt fixes

2731926

Merge branch 'fix/copy-new-registration-flow' into feat/new-regs-anal…

ba8df2d

…ytics

feat: wip analytics

bd4aaef

feat: wip analytics, sending events

f68ea4e

feat: wip analytics, sending events

d671984

feat: wip analytics, sending events

0d528c7

feat: add analytics to registration flows screens

bd87787

feat: add analytics to registration flows screens, add warmup for sdk

328e087

feat: add analytics to registration flows screens, add warmup for sdk

c01e5c3

Merge branch 'develop' into feat/new-regs-analytics

98ff06a

chore: update kalium ref

d6d667b

feat: init countly only when is allowed to

06f52f5

feat: perform cleanup and transfer id for user after registratiobn

e432433

feat: perform cleanup and transfer id for user after registratiobn

3c2a4ed

feat: perform cleanup and write test coverage

a49a2d0

feat: write test coverage

7601e83

feat: rename usecase

ad6a7d1

pull-request-size bot added the size/M label Jun 27, 2025

github-actions bot assigned yamilmedina Jun 27, 2025

yamilmedina changed the title ~~feat: new registration flows anonymous usage data (WPB-17529)~~ feat(new-registration): add flows anonymous usage data (WPB-17529) Jun 27, 2025

yamilmedina requested review from alexandreferris, MohamadJaara and saleniuk June 27, 2025 14:54

yamilmedina mentioned this pull request Jun 27, 2025

feat(new-registration): add use case to set analytics ID from the app (WPB-17529) wireapp/kalium#3494

Merged

7 tasks

Merge branch 'develop' into feat/new-regs-analytics

f7ad846

yamilmedina commented Jun 27, 2025

View reviewed changes

...src/main/kotlin/com/wire/android/ui/registration/details/CreateAccountDataDetailViewModel.kt Show resolved Hide resolved

yamilmedina commented Jun 27, 2025

View reviewed changes

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt Show resolved Hide resolved

yamilmedina commented Jun 27, 2025

View reviewed changes

...-enabled/src/main/kotlin/com/wire/android/feature/analytics/AnonymousAnalyticsManagerImpl.kt Show resolved Hide resolved

empty commit

9974f4e

alexandreferris reviewed Jun 27, 2025

View reviewed changes

app/src/main/kotlin/com/wire/android/analytics/FinalizeRegistrationAnalyticsMetadataUseCase.kt Show resolved Hide resolved

feat: test coverage

b14e65a

pull-request-size bot added size/L and removed size/M labels Jun 27, 2025

yamilmedina requested a review from Garzas June 30, 2025 10:32

saleniuk approved these changes Jul 2, 2025

View reviewed changes

Merge branch 'develop' into feat/new-regs-analytics

73d3830

MohamadJaara approved these changes Jul 3, 2025

View reviewed changes

MohamadJaara added this pull request to the merge queue Jul 3, 2025

yamilmedina removed this pull request from the merge queue due to a manual request Jul 3, 2025

chore: update kalium ref

91ac6c0

yamilmedina enabled auto-merge July 3, 2025 12:33

yamilmedina added this pull request to the merge queue Jul 3, 2025

Merged via the queue into develop with commit 9f1e574 Jul 3, 2025
17 of 19 checks passed

yamilmedina deleted the feat/new-regs-analytics branch July 3, 2025 13:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(new-registration): add flows anonymous usage data (WPB-17529) #4088

feat(new-registration): add flows anonymous usage data (WPB-17529) #4088

Uh oh!

yamilmedina commented Jun 27, 2025 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexandreferris left a comment

Uh oh!

Uh oh!

codecov bot commented Jun 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

Uh oh!

Uh oh!

feat(new-registration): add flows anonymous usage data (WPB-17529) #4088

feat(new-registration): add flows anonymous usage data (WPB-17529) #4088

Uh oh!

Conversation

yamilmedina commented Jun 27, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Solutions

Needs release with

Testing

Test Coverage (Optional)

How to Test

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexandreferris left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 3, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Uh oh!

Uh oh!

Uh oh!

yamilmedina commented Jun 27, 2025 •

edited by github-actions bot

Loading

codecov bot commented Jun 27, 2025 •

edited

Loading